Commit 2f37dc43 authored by Thorsten Blum's avatar Thorsten Blum Committed by Steve French
Browse files

smb: client: Don't log plaintext credentials in cifs_set_cifscreds 



When debug logging is enabled, cifs_set_cifscreds() logs the key
payload and exposes the plaintext username and password. Remove the
debug log to avoid exposing credentials.

Fixes: 8a8798a5 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts")
Cc: stable@vger.kernel.org
Acked-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.org>
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent d9d1e319

fs/smb/client/connect.c

+0 −1
Original line number Diff line number Diff line
@@ -2236,7 +2236,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struct cifs_ses *ses) 
	/* find first : in payload */

	payload = upayload->data;

	delim = strnchr(payload, upayload->datalen, ':');

	cifs_dbg(FYI, "payload=%s\n", payload);

	if (!delim) {

		cifs_dbg(FYI, "Unable to find ':' in payload (datalen=%d)\n",

			 upayload->datalen);