Commit 2f529e73 authored by Andrew Stellman's avatar Andrew Stellman Committed by Andrew Morton
Browse files

zram: reject unrecognized type= values in recompress_store() 

recompress_store() parses the type= parameter with three if statements
checking for "idle", "huge", and "huge_idle".  An unrecognized value
silently falls through with mode left at 0, causing the recompression pass
to run with no slot filter — processing all slots instead of the
intended subset.

Add a !mode check after the type parsing block to return -EINVAL for
unrecognized values, consistent with the function's other parameter
validation.

Link: https://lore.kernel.org/20260407153027.42425-1-astellman@stellman-greene.com


Signed-off-by: default avatarAndrew Stellman <astellman@stellman-greene.com>
Suggested-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9a8ea3c1

drivers/block/zram/zram_drv.c

+2 −0
Original line number Diff line number Diff line
@@ -2546,6 +2546,8 @@ static ssize_t recompress_store(struct device *dev, 
				mode = RECOMPRESS_HUGE;

			if (!strcmp(val, "huge_idle"))

				mode = RECOMPRESS_IDLE | RECOMPRESS_HUGE;

			if (!mode)

				return -EINVAL;

			continue;

		}