Commit 2f6a55e4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

io_uring: clean up a type in io_uring_register_get_file() 



Originally "fd" was unsigned int but it was changed to int when we pulled
this code into a separate function in commit 0b6d253e
("io_uring/register: provide helper to get io_ring_ctx from 'fd'").  This
doesn't really cause a runtime problem because the call to
array_index_nospec() will clamp negative fds to 0 and nothing else uses
the negative values.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/6f6cb630-079f-4fdf-bf95-1082e0a3fc6e@stanley.mountain


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7f44bead

io_uring/register.c

+1 −1
Original line number Diff line number Diff line
@@ -561,7 +561,7 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode, 
 * true, then the registered index is used. Otherwise, the normal fd table.

 * Caller must call fput() on the returned file, unless it's an ERR_PTR.

 */

struct file *io_uring_register_get_file(int fd, bool registered)

struct file *io_uring_register_get_file(unsigned int fd, bool registered)

{

	struct file *file;

io_uring/register.h

+1 −1
Original line number Diff line number Diff line
@@ -4,6 +4,6 @@ 


int io_eventfd_unregister(struct io_ring_ctx *ctx);

int io_unregister_personality(struct io_ring_ctx *ctx, unsigned id);

struct file *io_uring_register_get_file(int fd, bool registered);

struct file *io_uring_register_get_file(unsigned int fd, bool registered);



#endif