Unverified Commit 2f7bd9d6 authored by Louis Chauvet's avatar Louis Chauvet Committed by Maíra Canal
Browse files

drm/vkms: Add missing check for CRTC initialization 



CRTC initialization call drm_mode_crtc_set_gamma_size without the proper
checks, introduce this check to avoid issues.

Signed-off-by: default avatarLouis Chauvet <louis.chauvet@bootlin.com>
Reviewed-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Signed-off-by: default avatarMaíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240906-vkms-add-missing-check-v1-1-1afb3bf3d0a6@bootlin.com
parent 2b75feb3

drivers/gpu/drm/vkms/vkms_crtc.c

+6 −1
Original line number Diff line number Diff line
@@ -289,7 +289,12 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, 


	drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs);



	drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);

	ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);

	if (ret) {

		DRM_ERROR("Failed to set gamma size\n");

		return ret;

	}



	drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE);



	spin_lock_init(&vkms_out->lock);