Commit 3027e7b1 authored by Kunwu Chan's avatar Kunwu Chan Committed by Tony Nguyen
Browse files

ice: Fix some null pointer dereference issues in ice_ptp.c 



devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: d938a8cc ("ice: Auxbus devices & driver for E822 TS")
Cc: Kunwu Chan <kunwu.chan@hotmail.com>
Suggested-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent b8ab8858

drivers/net/ethernet/intel/ice/ice_ptp.c

+4 −0
Original line number Diff line number Diff line
@@ -2863,6 +2863,8 @@ static int ice_ptp_register_auxbus_driver(struct ice_pf *pf) 
	name = devm_kasprintf(dev, GFP_KERNEL, "ptp_aux_dev_%u_%u_clk%u",

			      pf->pdev->bus->number, PCI_SLOT(pf->pdev->devfn),

			      ice_get_ptp_src_clock_index(&pf->hw));

	if (!name)

		return -ENOMEM;



	aux_driver->name = name;

	aux_driver->shutdown = ice_ptp_auxbus_shutdown;
@@ -3109,6 +3111,8 @@ static int ice_ptp_create_auxbus_device(struct ice_pf *pf) 
	name = devm_kasprintf(dev, GFP_KERNEL, "ptp_aux_dev_%u_%u_clk%u",

			      pf->pdev->bus->number, PCI_SLOT(pf->pdev->devfn),

			      ice_get_ptp_src_clock_index(&pf->hw));

	if (!name)

		return -ENOMEM;



	aux_dev->name = name;

	aux_dev->id = id;