Unverified Commit 3061e170 authored by Cosmin Tanislav's avatar Cosmin Tanislav Committed by Mark Brown
Browse files

regmap: detach regmap from dev on regmap_exit 



At the end of __regmap_init(), if dev is not NULL, regmap_attach_dev()
is called, which adds a devres reference to the regmap, to be able to
retrieve a dev's regmap by name using dev_get_regmap().

When calling regmap_exit, the opposite does not happen, and the
reference is kept until the dev is detached.

Add a regmap_detach_dev() function and call it in regmap_exit() to make
sure that the devres reference is not kept.

Cc: stable@vger.kernel.org
Fixes: 72b39f6f ("regmap: Implement dev_get_regmap()")
Signed-off-by: default avatarCosmin Tanislav <demonsingur@gmail.com>
Rule: add
Link: https://lore.kernel.org/stable/20241128130554.362486-1-demonsingur%40gmail.com
Link: https://patch.msgid.link/20241128131625.363835-1-demonsingur@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3f1aa0c5

drivers/base/regmap/regmap.c

+12 −0
Original line number Diff line number Diff line
@@ -598,6 +598,17 @@ int regmap_attach_dev(struct device *dev, struct regmap *map, 
}

EXPORT_SYMBOL_GPL(regmap_attach_dev);



static int dev_get_regmap_match(struct device *dev, void *res, void *data);



static int regmap_detach_dev(struct device *dev, struct regmap *map)

{

	if (!dev)

		return 0;



	return devres_release(dev, dev_get_regmap_release,

			      dev_get_regmap_match, (void *)map->name);

}



static enum regmap_endian regmap_get_reg_endian(const struct regmap_bus *bus,

					const struct regmap_config *config)

{
@@ -1445,6 +1456,7 @@ void regmap_exit(struct regmap *map) 
{

	struct regmap_async *async;



	regmap_detach_dev(map->dev, map);

	regcache_exit(map);



	regmap_debugfs_exit(map);