Commit 306aec7e authored by Armin Wolf's avatar Armin Wolf Committed by Hans de Goede
Browse files

platform/x86: dell-smbios: Simplify error handling 



When the allocation of value_name fails, the error handling code
uses two gotos for error handling, which is not necessary.

Simplify the error handling in this case by only using a single goto.

Tested on a Dell Inspiron 3505.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240528204903.445546-2-W_Armin@gmx.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 1981b296

drivers/platform/x86/dell/dell-smbios-base.c

+4 −7
Original line number Diff line number Diff line
@@ -492,19 +492,16 @@ static int build_tokens_sysfs(struct platform_device *dev) 
		/* add value */

		value_name = kasprintf(GFP_KERNEL, "%04x_value",

				       da_tokens[i].tokenID);

		if (value_name == NULL)

			goto loop_fail_create_value;

		if (!value_name) {

			kfree(location_name);

			goto out_unwind_strings;

		}



		sysfs_attr_init(&token_entries[i].value_attr.attr);

		token_entries[i].value_attr.attr.name = value_name;

		token_entries[i].value_attr.attr.mode = 0444;

		token_entries[i].value_attr.show = value_show;

		token_attrs[j++] = &token_entries[i].value_attr.attr;

		continue;



loop_fail_create_value:

		kfree(location_name);

		goto out_unwind_strings;

	}

	smbios_attribute_group.attrs = token_attrs;