Commit 3093e6cc authored by Loic Poulain's avatar Loic Poulain Committed by Bartosz Golaszewski
Browse files

gpio: mxc: Fix disabled interrupt wake-up support 



A disabled/masked interrupt marked as wakeup source must be re-enable
and unmasked in order to be able to wake-up the host. That can be done
by flaging the irqchip with IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND.

Note: It 'sometimes' works without that change, but only thanks to the
lazy generic interrupt disabling (keeping interrupt unmasked).

Reported-by: default avatarMichal Koziel <michal.koziel@emlogic.no>
Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent dbec64b1

drivers/gpio/gpio-mxc.c

+1 −1
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ static int mxc_gpio_init_gc(struct mxc_gpio_port *port, int irq_base) 
	ct->chip.irq_unmask = irq_gc_mask_set_bit;

	ct->chip.irq_set_type = gpio_set_irq_type;

	ct->chip.irq_set_wake = gpio_set_wake_irq;

	ct->chip.flags = IRQCHIP_MASK_ON_SUSPEND;

	ct->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND;

	ct->regs.ack = GPIO_ISR;

	ct->regs.mask = GPIO_IMR;