Commit 30a32e93 authored by Hongbo Li's avatar Hongbo Li Committed by Bartosz Golaszewski
Browse files

gpio: Use IS_ERR_OR_NULL() helper function 



Use the IS_ERR_OR_NULL() helper instead of open-coding a
NULL and an error pointer checks to simplify the code and
improve readability.

No functional changes are intended.

Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
Link: https://lore.kernel.org/r/20240828122039.3697037-1-lihongbo22@huawei.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 931a36c4

drivers/gpio/gpiolib.c

+2 −2
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ int gpiod_get_direction(struct gpio_desc *desc) 
	 * We cannot use VALIDATE_DESC() as we must not return 0 for a NULL

	 * descriptor like we usually do.

	 */

	if (!desc || IS_ERR(desc))

	if (IS_ERR_OR_NULL(desc))

		return -EINVAL;



	CLASS(gpio_chip_guard, guard)(desc);
@@ -3591,7 +3591,7 @@ int gpiod_to_irq(const struct gpio_desc *desc) 
	 * requires this function to not return zero on an invalid descriptor

	 * but rather a negative error number.

	 */

	if (!desc || IS_ERR(desc))

	if (IS_ERR_OR_NULL(desc))

		return -EINVAL;



	gdev = desc->gdev;