Commit 30cc6aa0 authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: 3w-xxxx: Remove snprintf() from sysfs call-backs and replace with sysfs_emit() 

Since snprintf() has the documented, but still rather strange trait of
returning the length of the data that *would have been* written to the
array if space were available, rather than the arguably more useful
length of data *actually* written, it is usually considered wise to use
something else instead in order to avoid confusion.

In the case of sysfs call-backs, new wrappers exist that do just that.

Link: https://lwn.net/Articles/69419/
Link: https://github.com/KSPP/linux/issues/105


Cc: Adam Radford <aradford@gmail.com>
Cc: Joel Jacobson <linux@3ware.com>
Cc: de Melo <acme@conectiva.com.br>
Cc: Andre Hedrick <andre@suse.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20240111131732.1815560-4-lee@kernel.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7eaa48e9

drivers/scsi/3w-xxxx.c

+22 −22
Original line number Diff line number Diff line
@@ -496,7 +496,7 @@ static ssize_t tw_show_stats(struct device *dev, struct device_attribute *attr, 
	ssize_t len;



	spin_lock_irqsave(tw_dev->host->host_lock, flags);

	len = snprintf(buf, PAGE_SIZE, "3w-xxxx Driver version: %s\n"

	len = sysfs_emit(buf, "3w-xxxx Driver version: %s\n"

			 "Current commands posted:   %4d\n"

			 "Max commands posted:       %4d\n"

			 "Current pending commands:  %4d\n"