Commit 30d15b89 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: lp873x: use new GPIO line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250506-gpiochip-set-rv-gpio-part3-v1-1-0fbdea5a9667@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 6ac28cd2

drivers/gpio/gpio-lp873x.c

+6 −6
Original line number Diff line number Diff line
@@ -58,12 +58,12 @@ static int lp873x_gpio_get(struct gpio_chip *chip, unsigned int offset) 
	return val & BIT(offset * BITS_PER_GPO);

}



static void lp873x_gpio_set(struct gpio_chip *chip, unsigned int offset,

static int lp873x_gpio_set(struct gpio_chip *chip, unsigned int offset,

			   int value)

{

	struct lp873x_gpio *gpio = gpiochip_get_data(chip);



	regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,

	return regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,

				  BIT(offset * BITS_PER_GPO),

				  value ? BIT(offset * BITS_PER_GPO) : 0);

}
@@ -124,7 +124,7 @@ static const struct gpio_chip template_chip = { 
	.direction_input	= lp873x_gpio_direction_input,

	.direction_output	= lp873x_gpio_direction_output,

	.get			= lp873x_gpio_get,

	.set			= lp873x_gpio_set,

	.set_rv			= lp873x_gpio_set,

	.set_config		= lp873x_gpio_set_config,

	.base			= -1,

	.ngpio			= 2,