Commit 30d68cb0 authored by Frederick Lawler's avatar Frederick Lawler Committed by Roberto Sassu
Browse files

ima: process_measurement() needlessly takes inode_lock() on MAY_READ 



On IMA policy update, if a measure rule exists in the policy,
IMA_MEASURE is set for ima_policy_flags which makes the violation_check
variable always true. Coupled with a no-action on MAY_READ for a
FILE_CHECK call, we're always taking the inode_lock().

This becomes a performance problem for extremely heavy read-only workloads.
Therefore, prevent this only in the case there's no action to be taken.

Signed-off-by: default avatarFrederick Lawler <fred@cloudflare.com>
Acked-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
parent 9c32cda4

security/integrity/ima/ima_main.c

+3 −1
Original line number Diff line number Diff line
@@ -245,7 +245,9 @@ static int process_measurement(struct file *file, const struct cred *cred, 
				&allowed_algos);

	violation_check = ((func == FILE_CHECK || func == MMAP_CHECK ||

			    func == MMAP_CHECK_REQPROT) &&

			   (ima_policy_flag & IMA_MEASURE));

			   (ima_policy_flag & IMA_MEASURE) &&

			   ((action & IMA_MEASURE) ||

			    (file->f_mode & FMODE_WRITE)));

	if (!action && !violation_check)

		return 0;