Commit 30dd62fa authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Leon Romanovsky
Browse files

RDMA/core: Remove unused ib_ud_header_unpack 



ib_ud_header_unpack() is unused, and I can't see any sign of it
ever having been used in git.  The only reference I can find
is from December 2004 BKrev: 41d30034XNbBUl0XnyC6ig9V61Nf-A when
it looks like it was added.

Remove it.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20241221014021.343979-2-linux@treblig.org


Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 695df3e8

drivers/infiniband/core/ud_header.c

+0 −83
Original line number Diff line number Diff line
@@ -462,86 +462,3 @@ int ib_ud_header_pack(struct ib_ud_header *header, 
	return len;

}

EXPORT_SYMBOL(ib_ud_header_pack);
 


/**

 * ib_ud_header_unpack - Unpack UD header struct from wire format

 * @header:UD header struct

 * @buf:Buffer to pack into

 *

 * ib_ud_header_pack() unpacks the UD header structure @header from wire

 * format in the buffer @buf.

 */

int ib_ud_header_unpack(void                *buf,

			struct ib_ud_header *header)

{

	ib_unpack(lrh_table, ARRAY_SIZE(lrh_table),

		  buf, &header->lrh);

	buf += IB_LRH_BYTES;



	if (header->lrh.link_version != 0) {

		pr_warn("Invalid LRH.link_version %u\n",

			header->lrh.link_version);

		return -EINVAL;

	}



	switch (header->lrh.link_next_header) {

	case IB_LNH_IBA_LOCAL:

		header->grh_present = 0;

		break;



	case IB_LNH_IBA_GLOBAL:

		header->grh_present = 1;

		ib_unpack(grh_table, ARRAY_SIZE(grh_table),

			  buf, &header->grh);

		buf += IB_GRH_BYTES;



		if (header->grh.ip_version != 6) {

			pr_warn("Invalid GRH.ip_version %u\n",

				header->grh.ip_version);

			return -EINVAL;

		}

		if (header->grh.next_header != 0x1b) {

			pr_warn("Invalid GRH.next_header 0x%02x\n",

				header->grh.next_header);

			return -EINVAL;

		}

		break;



	default:

		pr_warn("Invalid LRH.link_next_header %u\n",

			header->lrh.link_next_header);

		return -EINVAL;

	}



	ib_unpack(bth_table, ARRAY_SIZE(bth_table),

		  buf, &header->bth);

	buf += IB_BTH_BYTES;



	switch (header->bth.opcode) {

	case IB_OPCODE_UD_SEND_ONLY:

		header->immediate_present = 0;

		break;

	case IB_OPCODE_UD_SEND_ONLY_WITH_IMMEDIATE:

		header->immediate_present = 1;

		break;

	default:

		pr_warn("Invalid BTH.opcode 0x%02x\n", header->bth.opcode);

		return -EINVAL;

	}



	if (header->bth.transport_header_version != 0) {

		pr_warn("Invalid BTH.transport_header_version %u\n",

			header->bth.transport_header_version);

		return -EINVAL;

	}



	ib_unpack(deth_table, ARRAY_SIZE(deth_table),

		  buf, &header->deth);

	buf += IB_DETH_BYTES;



	if (header->immediate_present)

		memcpy(&header->immediate_data, buf, sizeof header->immediate_data);



	return 0;

}

EXPORT_SYMBOL(ib_ud_header_unpack);

include/rdma/ib_pack.h

+0 −3
Original line number Diff line number Diff line
@@ -283,7 +283,4 @@ int ib_ud_header_init(int payload_bytes, 
int ib_ud_header_pack(struct ib_ud_header *header,

		      void                *buf);



int ib_ud_header_unpack(void                *buf,

			struct ib_ud_header *header);



#endif /* IB_PACK_H */