Commit 30e02ec3 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net: qdisc_pkt_len_segs_init() cleanup 



Reduce indentation level by returning early if the transport header
was not set.

Add an unlikely() clause as this is not the common case.

No functional change.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarJoe Damato <joe@dama.to>
Link: https://patch.msgid.link/20260403221540.3297753-2-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e65d8b6f

net/core/dev.c

+31 −31
Original line number Diff line number Diff line
@@ -4104,6 +4104,7 @@ EXPORT_SYMBOL_GPL(validate_xmit_skb_list); 
static void qdisc_pkt_len_segs_init(struct sk_buff *skb)

{

	struct skb_shared_info *shinfo = skb_shinfo(skb);

	unsigned int hdr_len;

	u16 gso_segs;



	qdisc_skb_cb(skb)->pkt_len = skb->len;
@@ -4117,8 +4118,8 @@ static void qdisc_pkt_len_segs_init(struct sk_buff *skb) 
	/* To get more precise estimation of bytes sent on wire,

	 * we add to pkt_len the headers size of all segments

	 */

	if (skb_transport_header_was_set(skb)) {

		unsigned int hdr_len;

	if (unlikely(!skb_transport_header_was_set(skb)))

		return;



	/* mac layer + network layer */

	if (!skb->encapsulation)
@@ -4155,7 +4156,6 @@ static void qdisc_pkt_len_segs_init(struct sk_buff *skb) 
	}

	qdisc_skb_cb(skb)->pkt_len += (gso_segs - 1) * hdr_len;

}

}



static int dev_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *q,

			     struct sk_buff **to_free,