Commit 30ed9ee9 authored by Mustafa Ismail's avatar Mustafa Ismail Committed by Leon Romanovsky
Browse files

RDMA/irdma: Do not generate SW completions for NOPs 



Currently, artificial SW completions are generated for NOP wqes which can
generate unexpected completions with wr_id = 0. Skip the generation of
artificial completions for NOPs.

Fixes: 81091d76 ("RDMA/irdma: Add SW mechanism to generate completions on error")
Signed-off-by: default avatarMustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Link: https://lore.kernel.org/r/20230315145231.931-2-shiraz.saleem@intel.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent eeac8ede

drivers/infiniband/hw/irdma/utils.c

+4 −1
Original line number Diff line number Diff line
@@ -2595,7 +2595,10 @@ void irdma_generate_flush_completions(struct irdma_qp *iwqp) 
			/* remove the SQ WR by moving SQ tail*/

			IRDMA_RING_SET_TAIL(*sq_ring,

				sq_ring->tail + qp->sq_wrtrk_array[sq_ring->tail].quanta);



			if (cmpl->cpi.op_type == IRDMAQP_OP_NOP) {

				kfree(cmpl);

				continue;

			}

			ibdev_dbg(iwqp->iwscq->ibcq.device,

				  "DEV: %s: adding wr_id = 0x%llx SQ Completion to list qp_id=%d\n",

				  __func__, cmpl->cpi.wr_id, qp->qp_id);