Commit 30eedf24 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: ezx-pcap: Avoid rescheduling after destroying workqueue 



Driver allocates workqueue and then registers additional interrupt
handler with devm interface.  This means that device removal will not
use a reversed order, but first destroy workqueue and then, via devm
release handlers, free the interrupt.

The interrupt handler registered with devm does not directly
use/schedule work items on the workqueue and the remove() function
correctly removes other IRQs handlers, however the code mixing devm and
non-devm interfaces is difficult to analyze and read.

Make the code flow much more obvious by using devm interface for
allocating the workqueue, so it will be freed with the rest of devm
resources.

Change is not equivalent in the workqueue itself: use non-legacy API
which does not set (__WQ_LEGACY | WQ_MEM_RECLAIM).  The workqueue is
used to update device registers, thus there is no point to run it for
memory reclaim.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20260305-workqueue-devm-v2-9-66a38741c652@oss.qualcomm.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent ef5a54c5

drivers/mfd/ezx-pcap.c

+2 −6
Original line number Diff line number Diff line
@@ -375,8 +375,6 @@ static void ezx_pcap_remove(struct spi_device *spi) 
	/* cleanup irqchip */

	for (i = pcap->irq_base; i < (pcap->irq_base + PCAP_NIRQS); i++)

		irq_set_chip_and_handler(i, NULL, NULL);



	destroy_workqueue(pcap->workqueue);

}



static int ezx_pcap_probe(struct spi_device *spi)
@@ -411,7 +409,7 @@ static int ezx_pcap_probe(struct spi_device *spi) 


	/* setup irq */

	pcap->irq_base = pdata->irq_base;

	pcap->workqueue = create_singlethread_workqueue("pcapd");

	pcap->workqueue = devm_alloc_ordered_workqueue(&spi->dev, "pcapd", 0);

	if (!pcap->workqueue)

		return -ENOMEM;
@@ -463,9 +461,7 @@ static int ezx_pcap_probe(struct spi_device *spi) 
free_irqchip:

	for (i = pcap->irq_base; i < (pcap->irq_base + PCAP_NIRQS); i++)

		irq_set_chip_and_handler(i, NULL, NULL);

/* destroy_workqueue: */

	destroy_workqueue(pcap->workqueue);

ret:



	return ret;

}