Commit 311ead1b authored by Guopeng Zhang's avatar Guopeng Zhang Committed by Tejun Heo
Browse files

selftests: cgroup: Add cg_read_key_long_poll() to poll a cgroup key with retries 



Introduce a new helper function `cg_read_key_long_poll()` in
cgroup_util.h. This function polls the specified key in a cgroup file
until it matches the expected value or the retry limit is reached,
with configurable wait intervals between retries.

This helper is particularly useful for handling asynchronously updated
cgroup statistics (e.g., memory.stat), where immediate reads may
observe stale values, especially on busy systems. It allows tests and
other utilities to handle such cases more flexibly.

Signed-off-by: default avatarGuopeng Zhang <zhangguopeng@kylinos.cn>
Suggested-by: default avatarMichal Koutný <mkoutny@suse.com>
Reviewed-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Acked-by: default avatarMichal Koutný <mkoutny@suse.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 3309b63a

tools/testing/selftests/cgroup/lib/cgroup_util.c

+21 −0
Original line number Diff line number Diff line
@@ -168,6 +168,27 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key) 
	return atol(ptr + strlen(key));

}



long cg_read_key_long_poll(const char *cgroup, const char *control,

			   const char *key, long expected, int retries,

			   useconds_t wait_interval_us)

{

	long val = -1;

	int i;



	for (i = 0; i < retries; i++) {

		val = cg_read_key_long(cgroup, control, key);

		if (val < 0)

			return val;



		if (val == expected)

			break;



		usleep(wait_interval_us);

	}



	return val;

}



long cg_read_lc(const char *cgroup, const char *control)

{

	char buf[PAGE_SIZE];

tools/testing/selftests/cgroup/lib/include/cgroup_util.h

+5 −0
Original line number Diff line number Diff line
@@ -17,6 +17,8 @@ 
#define CG_NAMED_NAME "selftest"

#define CG_PATH_FORMAT (!cg_test_v1_named ? "0::%s" : (":name=" CG_NAMED_NAME ":%s"))



#define DEFAULT_WAIT_INTERVAL_US (100 * 1000) /* 100 ms */



/*

 * Checks if two given values differ by less than err% of their sum.

 */
@@ -64,6 +66,9 @@ extern int cg_read_strstr(const char *cgroup, const char *control, 
extern long cg_read_long(const char *cgroup, const char *control);

extern long cg_read_long_fd(int fd);

long cg_read_key_long(const char *cgroup, const char *control, const char *key);

long cg_read_key_long_poll(const char *cgroup, const char *control,

			   const char *key, long expected, int retries,

			   useconds_t wait_interval_us);

extern long cg_read_lc(const char *cgroup, const char *control);

extern int cg_write(const char *cgroup, const char *control, char *buf);

extern int cg_open(const char *cgroup, const char *control, int flags);