Commit 315b40df authored by Akhil R's avatar Akhil R Committed by Andi Shyti
Browse files

i2c: tegra: Remove dma_sync_*() calls 



Calling dma_sync_*() on a buffer from dma_alloc_coherent() is pointless.
The driver should not be doing its own bounce-buffering if the buffer is
allocated through dma_alloc_coherent().

Suggested-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarAkhil R <akhilrajeev@nvidia.com>
Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20250710131206.2316-4-akhilrajeev@nvidia.com
parent 635bf3c8

drivers/i2c/busses/i2c-tegra.c

+1 −19
Original line number Diff line number Diff line
@@ -1301,17 +1301,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 


	if (i2c_dev->dma_mode) {

		if (i2c_dev->msg_read) {

			dma_sync_single_for_device(i2c_dev->dma_dev,

						   i2c_dev->dma_phys,

						   xfer_size, DMA_FROM_DEVICE);



			err = tegra_i2c_dma_submit(i2c_dev, xfer_size);

			if (err)

				return err;

		} else {

			dma_sync_single_for_cpu(i2c_dev->dma_dev,

						i2c_dev->dma_phys,

						xfer_size, DMA_TO_DEVICE);

		}

	}
@@ -1321,11 +1313,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
		if (i2c_dev->dma_mode) {

			memcpy(i2c_dev->dma_buf + I2C_PACKET_HEADER_SIZE,

			       msg->buf, i2c_dev->msg_len);



			dma_sync_single_for_device(i2c_dev->dma_dev,

						   i2c_dev->dma_phys,

						   xfer_size, DMA_TO_DEVICE);



			err = tegra_i2c_dma_submit(i2c_dev, xfer_size);

			if (err)

				return err;
@@ -1366,14 +1353,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
			return -ETIMEDOUT;

		}



		if (i2c_dev->msg_read && i2c_dev->msg_err == I2C_ERR_NONE) {

			dma_sync_single_for_cpu(i2c_dev->dma_dev,

						i2c_dev->dma_phys,

						xfer_size, DMA_FROM_DEVICE);



		if (i2c_dev->msg_read && i2c_dev->msg_err == I2C_ERR_NONE)

			memcpy(i2c_dev->msg_buf, i2c_dev->dma_buf, i2c_dev->msg_len);

	}

	}



	time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete,

					      xfer_time);