Commit 315deab2 authored by Gergo Koteles's avatar Gergo Koteles Committed by Takashi Iwai
Browse files

ALSA: hda/tas2781: reset the amp before component_add 



Calling component_add starts loading the firmware, the callback function
writes the program to the amplifiers. If the module resets the
amplifiers after component_add, it happens that one of the amplifiers
does not work because the reset and program writing are interleaving.

Call tas2781_reset before component_add to ensure reliable
initialization.

Fixes: 5be27f1e ("ALSA: hda/tas2781: Add tas2781 HDA driver")
CC: stable@vger.kernel.org
Signed-off-by: default avatarGergo Koteles <soyer@irl.hu>
Link: https://lore.kernel.org/r/4d23bf58558e23ee8097de01f70f1eb8d9de2d15.1702511246.git.soyer@irl.hu


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6c6fa264

sound/pci/hda/tas2781_hda_i2c.c

+2 −2
Original line number Diff line number Diff line
@@ -674,14 +674,14 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) 


	pm_runtime_put_autosuspend(tas_priv->dev);



	tas2781_reset(tas_priv);



	ret = component_add(tas_priv->dev, &tas2781_hda_comp_ops);

	if (ret) {

		dev_err(tas_priv->dev, "Register component failed: %d\n", ret);

		pm_runtime_disable(tas_priv->dev);

		goto err;

	}



	tas2781_reset(tas_priv);

err:

	if (ret)

		tas2781_hda_remove(&clt->dev);