Commit 319b6d4e authored Apr 19, 2024 by Alex Elder Committed by Paolo Abeni Apr 23, 2024

net: ipa: fix two minor ipa_cmd problems



In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function
does not exist.  So delete that declaration.

Also, for some reason ipa_cmd_init() never gets called.  It isn't
really critical--it just validates that some memory offsets and a
size can be represented in some register fields, and they won't fail
with current data.  Regardless, call the function in ipa_probe().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

parent f2e4e9ea

drivers/net/ipa/ipa_cmd.h

+0 −8

Original line number	Diff line number	Diff line
		@@ -53,14 +53,6 @@ enum ipa_cmd_opcode {
		bool ipa_cmd_table_init_valid(struct ipa ipa, const struct ipa_mem mem,
		bool route);

		/**
		* ipa_cmd_data_valid() - Validate command-realted configuration is valid
		* @ipa: - IPA pointer
		*
		* Return: true if assumptions required for command are valid
		*/
		bool ipa_cmd_data_valid(struct ipa *ipa);

		/**
		* ipa_cmd_pool_init() - initialize command channel pools
		* @channel: AP->IPA command TX GSI channel pointer

drivers/net/ipa/ipa_main.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -865,6 +865,10 @@ static int ipa_probe(struct platform_device *pdev)
		if (ret)
		goto err_reg_exit;

		ret = ipa_cmd_init(ipa);
		if (ret)
		goto err_mem_exit;

		ret = gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count,
		data->endpoint_data);
		if (ret)