Commit 31edf4bb authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Jens Axboe
Browse files

nbd: null check for nla_nest_start 



nla_nest_start() may fail and return NULL. Insert a check and set errno
based on other call sites within the same source code.

Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: default avatarMichal Kubecek <mkubecek@suse.cz>
Fixes: 47d902b9 ("nbd: add a status netlink command")
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20240218042534.it.206-kees@kernel.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d69591ca

drivers/block/nbd.c

+6 −0
Original line number Diff line number Diff line
@@ -2433,6 +2433,12 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info) 
	}



	dev_list = nla_nest_start_noflag(reply, NBD_ATTR_DEVICE_LIST);

	if (!dev_list) {

		nlmsg_free(reply);

		ret = -EMSGSIZE;

		goto out;

	}



	if (index == -1) {

		ret = idr_for_each(&nbd_index_idr, &status_cb, reply);

		if (ret) {