Unverified Commit 31ef579d authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: qcom: fix Kconfig for SC7280 



select would force the symbol to value without checking the dependencies.
In this case selecting TX and RX MACROs directly without checking its
dependency on COMMON_CLK would break builds on platform which do no
set COMMON_CLK.
ex:
WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO
  Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n]
  Selected by [m]:
  - SND_SOC_SC7280 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] &&
	 SND_SOC_QCOM [=m] && I2C [=y] && SOUNDWIRE [=m]

move select to imply which should enforce symbol to be set to 'n' if any
dependencies are not resolved.

Fixes: 57350bd4 ("ASoC: qcom: SC7280: Add machine driver")
Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220309140552.8065-1-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 81acac8c

sound/soc/qcom/Kconfig

+2 −2
Original line number Diff line number Diff line
@@ -195,8 +195,8 @@ config SND_SOC_SC7280 
	select SND_SOC_MAX98357A

	select SND_SOC_WCD938X_SDW

	select SND_SOC_LPASS_MACRO_COMMON

	select SND_SOC_LPASS_RX_MACRO

	select SND_SOC_LPASS_TX_MACRO

	imply SND_SOC_LPASS_RX_MACRO

	imply SND_SOC_LPASS_TX_MACRO

	help

	  Add support for audio on Qualcomm Technologies Inc.

	  SC7280 SoC-based systems.