Commit 3278c42b authored May 31, 2023 by Benjamin Berg Committed by Johannes Berg Jun 06, 2023

wifi: iwlwifi: do not log undefined DRAM buffers unnecessarily

DRAM buffers that are not defined in the TLVs (or are unused in the
preset) would cause a log message. To avoid confusion, skip processing
buffers with an invalid (i.e. uninitialized) DRAM path.

This further reduces the noise of the message in cases where it is
unlikely to be helpful. Also update a related debug log string to better
describe what is happening.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230531194629.ecae60cf2d7f.Ib44a94d4aeb55dbb2e52edea8b69a09bc0f722c3@changeid

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 7bc57ca9

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -738,7 +738,8 @@ static int iwl_dbg_tlv_update_dram(struct iwl_fw_runtime *fwrt,

		if (le32_to_cpu(fwrt->trans->dbg.fw_mon_cfg[alloc_id].buf_location) !=
		IWL_FW_INI_LOCATION_DRAM_PATH) {
		IWL_DEBUG_FW(fwrt, "DRAM_PATH is not supported alloc_id %u\n", alloc_id);
		IWL_DEBUG_FW(fwrt, "WRT: alloc_id %u location is not in DRAM_PATH\n",
		alloc_id);
		return -1;
		}

		@@ -799,6 +800,10 @@ static void iwl_dbg_tlv_update_drams(struct iwl_fw_runtime *fwrt)

		for (i = IWL_FW_INI_ALLOCATION_ID_DBGC1;
		i < IWL_FW_INI_ALLOCATION_NUM; i++) {
		if (fwrt->trans->dbg.fw_mon_cfg[i].buf_location ==
		IWL_FW_INI_LOCATION_INVALID)
		continue;

		ret = iwl_dbg_tlv_update_dram(fwrt, i, dram_info);
		if (!ret)
		dram_alloc = true;