Commit 32e4a544 authored by Luiz Angelo Daros de Luca's avatar Luiz Angelo Daros de Luca Committed by Jakub Kicinski
Browse files

net: dsa: realtek: fix digital interface select macro for EXT0 



While no supported devices currently utilize EXT0, the register reserves
the bits for an EXT0. EXT0 is utilized by devices from the generation
prior to rtl8365mb, such as those supported by the driver library
rtl8367b.

Signed-off-by: default avatarLuiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: default avatarAlvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240212-realtek-fix_ext0-v1-1-f3d2536d191a@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 239ce99c

drivers/net/dsa/realtek/rtl8365mb.c

+2 −2
Original line number Diff line number Diff line
@@ -209,10 +209,10 @@ 
#define RTL8365MB_EXT_PORT_MODE_100FX		13



/* External interface mode configuration registers 0~1 */

#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0		0x1305 /* EXT1 */

#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0		0x1305 /* EXT0,EXT1 */

#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1		0x13C3 /* EXT2 */

#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extint) \

		((_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \

		((_extint) <= 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \

		 (_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \

		 0x0)

#define   RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \