Commit 32e5a120 authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Thierry Reding
Browse files

drm/tegra: put drm_gem_object ref on error in tegra_fb_create 



Inside tegra_fb_create(), drm_gem_object_lookup() increments ref count of
the found object. But if the following size check fails then the last
found object's ref count should be put there as the unreferencing loop
can't detect this situation.

Found by Linux Verification Center (linuxtesting.org).

Fixes: de2ba664 ("gpu: host1x: drm: Add memory manager and fb")
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231215093356.12067-1-pchelkin@ispras.ru
parent a3baaca4

drivers/gpu/drm/tegra/fb.c

+1 −0
Original line number Diff line number Diff line
@@ -159,6 +159,7 @@ struct drm_framebuffer *tegra_fb_create(struct drm_device *drm, 


		if (gem->size < size) {

			err = -EINVAL;

			drm_gem_object_put(gem);

			goto unreference;

		}