Commit 32f59301 authored by Sanman Pradhan's avatar Sanman Pradhan Committed by Guenter Roeck
Browse files

hwmon: (pmbus/ina233) Add error check for pmbus_read_word_data() return value 



ina233_read_word_data() uses the return value of pmbus_read_word_data()
directly in a DIV_ROUND_CLOSEST() computation without first checking for
errors. If the underlying I2C transaction fails, a negative error code is
used in the arithmetic, producing a garbage sensor value instead of
propagating the error.

Add the missing error check before using the return value.

Fixes: b64b6cb1 ("hwmon: Add driver for TI INA233 Current and Power Monitor")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarSanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260317174553.385567-1-sanman.pradhan@hpe.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent c6f45ed2

drivers/hwmon/pmbus/ina233.c

+2 −0
Original line number Diff line number Diff line
@@ -67,6 +67,8 @@ static int ina233_read_word_data(struct i2c_client *client, int page, 
	switch (reg) {

	case PMBUS_VIRT_READ_VMON:

		ret = pmbus_read_word_data(client, 0, 0xff, MFR_READ_VSHUNT);

		if (ret < 0)

			return ret;



		/* Adjust returned value to match VIN coefficients */

		/* VIN: 1.25 mV VSHUNT: 2.5 uV LSB */