Commit 330995bb authored by Abraham Samuel Adekunle's avatar Abraham Samuel Adekunle Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: gmin: Remove duplicate NULL test 



When a value has been tested for NULL in an expression, a
second NULL test on the same value in another expression
is unnecessary when the value has not been assigned NULL.

Remove unnecessary duplicate NULL tests on the same value that
has previously been NULL tested.

Found by Coccinelle.

Signed-off-by: default avatarAbraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Link: https://lore.kernel.org/r/26990d4a9d4419f9d4155a40595bc213acb671a0.1743685415.git.abrahamadekunle50@gmail.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent e0798057

drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

+1 −1
Original line number Diff line number Diff line
@@ -1206,7 +1206,7 @@ static int gmin_get_config_dsm_var(struct device *dev, 
	 * if it founds something different than string, letting it

	 * to fall back to the old code.

	 */

	if (cur && cur->type != ACPI_TYPE_STRING) {

	if (cur->type != ACPI_TYPE_STRING) {

		dev_info(dev, "found non-string _DSM entry for '%s'\n", var);

		ACPI_FREE(obj);

		return -EINVAL;