Commit 334dc5fc authored by Tao Zhou's avatar Tao Zhou Committed by Alex Deucher
Browse files

drm/amdgpu: increase RAS bad page threshold 



For default policy, driver will issue an RMA event when the number of
bad pages is greater than 8 physical rows, rather than reaches 8
physical rows, don't rely on threshold configurable parameters in
default mode.

Signed-off-by: default avatarTao Zhou <tao.zhou1@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent fe2fa3be

drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c

+3 −3
Original line number Diff line number Diff line
@@ -747,7 +747,7 @@ amdgpu_ras_eeprom_update_header(struct amdgpu_ras_eeprom_control *control) 
	/* Modify the header if it exceeds.

	 */

	if (amdgpu_bad_page_threshold != 0 &&

	    control->ras_num_bad_pages >= ras->bad_page_cnt_threshold) {

	    control->ras_num_bad_pages > ras->bad_page_cnt_threshold) {

		dev_warn(adev->dev,

			"Saved bad pages %d reaches threshold value %d\n",

			control->ras_num_bad_pages, ras->bad_page_cnt_threshold);
@@ -806,7 +806,7 @@ amdgpu_ras_eeprom_update_header(struct amdgpu_ras_eeprom_control *control) 
	 */

	if (amdgpu_bad_page_threshold != 0 &&

	    control->tbl_hdr.version == RAS_TABLE_VER_V2_1 &&

	    control->ras_num_bad_pages < ras->bad_page_cnt_threshold)

	    control->ras_num_bad_pages <= ras->bad_page_cnt_threshold)

		control->tbl_rai.health_percent = ((ras->bad_page_cnt_threshold -

						   control->ras_num_bad_pages) * 100) /

						   ras->bad_page_cnt_threshold;
@@ -1456,7 +1456,7 @@ int amdgpu_ras_eeprom_check(struct amdgpu_ras_eeprom_control *control) 
				res);

			return -EINVAL;

		}

		if (ras->bad_page_cnt_threshold > control->ras_num_bad_pages) {

		if (ras->bad_page_cnt_threshold >= control->ras_num_bad_pages) {

			/* This means that, the threshold was increased since

			 * the last time the system was booted, and now,

			 * ras->bad_page_cnt_threshold - control->num_recs > 0,