Commit 33507b39 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Martin K. Petersen
Browse files

scsi: ufs: qcom: Add sanity checks for gear/lane values during ICC scaling 



Let's add the checks to warn the user if the ICC scaling is not supported
for the gear/lane values and also fallback to the max value if that's the
case.

Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20240403-ufs-icc-fix-v2-2-958412a5eb45@linaro.org


Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 83ef2ab4

drivers/ufs/host/ufs-qcom.c

+10 −0
Original line number Diff line number Diff line
@@ -687,6 +687,16 @@ static struct __ufs_qcom_bw_table ufs_qcom_get_bw_table(struct ufs_qcom_host *ho 
	int gear = max_t(u32, p->gear_rx, p->gear_tx);

	int lane = max_t(u32, p->lane_rx, p->lane_tx);



	if (WARN_ONCE(gear > QCOM_UFS_MAX_GEAR,

		      "ICC scaling for UFS Gear (%d) not supported. Using Gear (%d) bandwidth\n",

		      gear, QCOM_UFS_MAX_GEAR))

		gear = QCOM_UFS_MAX_GEAR;



	if (WARN_ONCE(lane > QCOM_UFS_MAX_LANE,

		      "ICC scaling for UFS Lane (%d) not supported. Using Lane (%d) bandwidth\n",

		      lane, QCOM_UFS_MAX_LANE))

		lane = QCOM_UFS_MAX_LANE;



	if (ufshcd_is_hs_mode(p)) {

		if (p->hs_rate == PA_HS_MODE_B)

			return ufs_qcom_bw_table[MODE_HS_RB][gear][lane];