Commit 33566288 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: phylink: use for_each_set_bit() 



Use for_each_set_bit() rather than open coding the for() test_bit()
loop.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarWojciech Drewek <wojciech.drewek@intel.com>
Link: https://lore.kernel.org/r/E1r4p15-00Cpxe-C7@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 79a4f4df

drivers/net/phy/phylink.c

+8 −10
Original line number Diff line number Diff line
@@ -697,20 +697,18 @@ static int phylink_validate_mask(struct phylink *pl, unsigned long *supported, 
	__ETHTOOL_DECLARE_LINK_MODE_MASK(all_s) = { 0, };

	__ETHTOOL_DECLARE_LINK_MODE_MASK(s);

	struct phylink_link_state t;

	int intf;

	int interface;



	for (intf = 0; intf < PHY_INTERFACE_MODE_MAX; intf++) {

		if (test_bit(intf, interfaces)) {

	for_each_set_bit(interface, interfaces, PHY_INTERFACE_MODE_MAX) {

		linkmode_copy(s, supported);



		t = *state;

			t.interface = intf;

		t.interface = interface;

		if (!phylink_validate_mac_and_pcs(pl, s, &t)) {

			linkmode_or(all_s, all_s, s);

			linkmode_or(all_adv, all_adv, t.advertising);

		}

	}

	}



	linkmode_copy(supported, all_s);

	linkmode_copy(state->advertising, all_adv);