Commit 33928ed8 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

sched/balancing: Update comments in 'struct sg_lb_stats' and 'struct sd_lb_stats' 



- Align for readability
- Capitalize consistently

Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240308105901.1096078-11-mingo@kernel.org
parent e492e1b0

kernel/sched/fair.c

+9 −10
Original line number Diff line number Diff line
@@ -9433,17 +9433,17 @@ static void update_blocked_averages(int cpu) 
/********** Helpers for find_busiest_group ************************/



/*

 * sg_lb_stats - stats of a sched_group required for load_balancing

 * sg_lb_stats - stats of a sched_group required for load-balancing:

 */

struct sg_lb_stats {

	unsigned long avg_load;			/* Avg load across the CPUs of the group */

	unsigned long avg_load;			/* Avg load            over the CPUs of the group */

	unsigned long group_load;		/* Total load          over the CPUs of the group */

	unsigned long group_capacity;

	unsigned long group_capacity;		/* Capacity            over the CPUs of the group */

	unsigned long group_util;		/* Total utilization   over the CPUs of the group */

	unsigned long group_runnable;		/* Total runnable time over the CPUs of the group */

	unsigned int sum_nr_running;		/* Nr of tasks running in the group */

	unsigned int sum_nr_running;		/* Nr of all tasks running in the group */

	unsigned int sum_h_nr_running;		/* Nr of CFS tasks running in the group */

	unsigned int idle_cpus;

	unsigned int idle_cpus;                 /* Nr of idle CPUs         in the group */

	unsigned int group_weight;

	enum group_type group_type;

	unsigned int group_asym_packing;	/* Tasks should be moved to preferred CPU */
@@ -9456,8 +9456,7 @@ struct sg_lb_stats { 
};



/*

 * sd_lb_stats - Structure to store the statistics of a sched_domain

 *		 during load balancing.

 * sd_lb_stats - stats of a sched_domain required for load-balancing:

 */

struct sd_lb_stats {

	struct sched_group *busiest;		/* Busiest group in this sd */
@@ -9465,7 +9464,7 @@ struct sd_lb_stats { 
	unsigned long total_load;		/* Total load of all groups in sd */

	unsigned long total_capacity;		/* Total capacity of all groups in sd */

	unsigned long avg_load;			/* Average load across all groups in sd */

	unsigned int prefer_sibling;		/* tasks should go to sibling first */

	unsigned int prefer_sibling;		/* Tasks should go to sibling first */



	struct sg_lb_stats busiest_stat;	/* Statistics of the busiest group */

	struct sg_lb_stats local_stat;		/* Statistics of the local group */