Commit 33ba21e9 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/log: Do not hold lock across drm_client_release() 



When calling drm_client_release(), the client is already quiescent.
Internal locks should therefore be dropped before the caller releases
the client.

In the case of the DRM log, concurrency originates from the console or
from client events. The console has been unregistered in the previous
line. The caller of the unregister callback, drm_log_client_unregister(),
holds clientlist_mutex from struct drm_device to protect against concurrent
client events. It is therefore safe to release the client without holding
locks.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJocelyn Falempe <jfalempe@redhat.com&gt;>
Link: https://lore.kernel.org/r/20251009132006.45834-3-tzimmermann@suse.de
parent a16f6ba4

drivers/gpu/drm/clients/drm_log.c

+1 −1
Original line number Diff line number Diff line
@@ -302,8 +302,8 @@ static void drm_log_client_unregister(struct drm_client_dev *client) 


	mutex_lock(&dlog->lock);

	drm_log_free_scanout(client);

	drm_client_release(client);

	mutex_unlock(&dlog->lock);

	drm_client_release(client);

	kfree(dlog);

	drm_dbg(dev, "Unregistered with drm log\n");

}