Commit 3401f63e authored by Amit Shah's avatar Amit Shah Committed by Herbert Xu
Browse files

crypto: ccp - do not request interrupt on cmd completion when irqs disabled 



While sending a command to the PSP, we always requested an interrupt
from the PSP after command completion.  This worked for most cases.  For
the special case of irqs being disabled -- e.g. when running within
crashdump or kexec contexts, we should not set the SEV_CMDRESP_IOC flag,
so the PSP knows to not attempt interrupt delivery.

Fixes: 8ef97958 ("crypto: ccp: Add panic notifier for SEV/SNP firmware shutdown on kdump")

Based-on-patch-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarAmit Shah <amit.shah@amd.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent c299d7af

drivers/crypto/ccp/sev-dev.c

+12 −1
Original line number Diff line number Diff line
@@ -910,7 +910,18 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret) 


	sev->int_rcvd = 0;



	reg = FIELD_PREP(SEV_CMDRESP_CMD, cmd) | SEV_CMDRESP_IOC;

	reg = FIELD_PREP(SEV_CMDRESP_CMD, cmd);



	/*

	 * If invoked during panic handling, local interrupts are disabled so

	 * the PSP command completion interrupt can't be used.

	 * sev_wait_cmd_ioc() already checks for interrupts disabled and

	 * polls for PSP command completion.  Ensure we do not request an

	 * interrupt from the PSP if irqs disabled.

	 */

	if (!irqs_disabled())

		reg |= SEV_CMDRESP_IOC;



	iowrite32(reg, sev->io_regs + sev->vdata->cmdresp_reg);



	/* wait for command completion */