Commit 3414adbd authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Jakub Kicinski
Browse files

lwt: Don't disable migration prio invoking BPF. 



There is no need to explicitly disable migration if bottom halves are
also disabled. Disabling BH implies disabling migration.

Remove migrate_disable() and rely solely on disabling BH to remain on
the same CPU.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20240620132727.660738-12-bigeasy@linutronix.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b22800f9

net/core/lwt_bpf.c

+2 −4
Original line number Diff line number Diff line
@@ -40,10 +40,9 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt, 
{

	int ret;



	/* Migration disable and BH disable are needed to protect per-cpu

	 * redirect_info between BPF prog and skb_do_redirect().

	/* Disabling BH is needed to protect per-CPU bpf_redirect_info between

	 * BPF prog and skb_do_redirect().

	 */

	migrate_disable();

	local_bh_disable();

	bpf_compute_data_pointers(skb);

	ret = bpf_prog_run_save_cb(lwt->prog, skb);
@@ -78,7 +77,6 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt, 
	}



	local_bh_enable();

	migrate_enable();



	return ret;

}