Commit 347d8483 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans Verkuil
Browse files

media: xilinx-tpg: fix double put in xtpg_parse_of() 



This loop was recently converted to use for_each_of_graph_port() which
automatically does __cleanup__ on the "port" iterator variable.  Delete
the calls to of_node_put(port) to avoid a double put bug.

Fixes: 393194cd ("media: xilinx-tpg: use new of_graph functions")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 734ac57e

drivers/media/platform/xilinx/xilinx-tpg.c

+0 −2
Original line number Diff line number Diff line
@@ -722,7 +722,6 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) 
		format = xvip_of_get_format(port);

		if (IS_ERR(format)) {

			dev_err(dev, "invalid format in DT");

			of_node_put(port);

			return PTR_ERR(format);

		}
@@ -731,7 +730,6 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) 
			xtpg->vip_format = format;

		} else if (xtpg->vip_format != format) {

			dev_err(dev, "in/out format mismatch in DT");

			of_node_put(port);

			return -EINVAL;

		}