Commit 348769d1 authored by Fei Yang's avatar Fei Yang Committed by Matt Roper
Browse files

drm/xe: correct the assertion for number of PTEs 



While one MI_STORE_DATA_IMM can take no more than 0x1fe qwords,
the size of the pgtable can be 512 entries.

Fixes: 43d48379 ("drm/xe: correct the calculation of remaining size")
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: default avatarFei Yang <fei.yang@intel.com>
Tested-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240125065245.1204731-2-fei.yang@intel.com
parent d688b86a

drivers/gpu/drm/xe/xe_migrate.c

+2 −1
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ struct xe_migrate { 
#define NUM_KERNEL_PDE 17

#define NUM_PT_SLOTS 32

#define LEVEL0_PAGE_TABLE_ENCODE_SIZE SZ_2M

#define MAX_NUM_PTE 512



/*

 * Although MI_STORE_DATA_IMM's "length" field is 10-bits, 0x3FE is the largest
@@ -1107,7 +1108,7 @@ static void write_pgtable(struct xe_tile *tile, struct xe_bb *bb, u64 ppgtt_ofs, 
	 * This shouldn't be possible in practice.. might change when 16K

	 * pages are used. Hence the assert.

	 */

	xe_tile_assert(tile, update->qwords <= MAX_PTE_PER_SDI);

	xe_tile_assert(tile, update->qwords < MAX_NUM_PTE);

	if (!ppgtt_ofs)

		ppgtt_ofs = xe_migrate_vram_ofs(tile_to_xe(tile),

						xe_bo_addr(update->pt_bo, 0,