Commit 349f02c0 authored by Brian Masney's avatar Brian Masney Committed by Bjorn Andersson
Browse files

clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate() 



The divider_ro_round_rate() function is now deprecated, so let's migrate
to divider_ro_determine_rate() instead so that this deprecated API can
be removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: b6f90511 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
Signed-off-by: default avatarBrian Masney <bmasney@redhat.com>
Reviewed-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260108-clk-divider-round-rate-v1-15-535a3ed73bf3@redhat.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent e1f08613

drivers/clk/qcom/clk-regmap-divider.c

+2 −6
Original line number Diff line number Diff line
@@ -26,12 +26,8 @@ static int div_ro_determine_rate(struct clk_hw *hw, 
	val >>= divider->shift;

	val &= BIT(divider->width) - 1;



	req->rate = divider_ro_round_rate(hw, req->rate,

					  &req->best_parent_rate, NULL,

					  divider->width,

	return divider_ro_determine_rate(hw, req, NULL, divider->width,

					 CLK_DIVIDER_ROUND_CLOSEST, val);



	return 0;

}



static int div_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)