Commit 34a6a003 authored by Florian Westphal's avatar Florian Westphal
Browse files

netfilter: nfnetlink_queue: remove locking in nfqnl_get_sk_secctx 



We don't need the cb lock here.
Also, if skb was NULL we'd have crashed already.

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
parent 013e2f91

net/netfilter/nfnetlink_queue.c

+0 −7
Original line number Diff line number Diff line
@@ -592,15 +592,8 @@ static int nfqnl_get_sk_secctx(struct sk_buff *skb, struct lsm_context *ctx) 
{

	int seclen = 0;

#if IS_ENABLED(CONFIG_NETWORK_SECMARK)



	if (!skb || !sk_fullsock(skb->sk))

		return 0;



	read_lock_bh(&skb->sk->sk_callback_lock);



	if (skb->secmark)

		seclen = security_secid_to_secctx(skb->secmark, ctx);

	read_unlock_bh(&skb->sk->sk_callback_lock);

#endif

	return seclen;

}