Commit 34b4540e authored by Haifeng Xu's avatar Haifeng Xu Committed by Amir Goldstein
Browse files

ovl: don't set the superblock's errseq_t manually 



Since commit 5679897e ("vfs: make sync_filesystem return errors from
->sync_fs"), the return value from sync_fs callback can be seen in
sync_filesystem(). Thus the errseq_set opreation can be removed here.

Depends-on: commit 5679897e ("vfs: make sync_filesystem return errors from ->sync_fs")
Signed-off-by: default avatarHaifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
parent 3e9bff3b

fs/overlayfs/super.c

+2 −8
Original line number Diff line number Diff line
@@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait) 
	int ret;



	ret = ovl_sync_status(ofs);

	/*

	 * We have to always set the err, because the return value isn't

	 * checked in syncfs, and instead indirectly return an error via

	 * the sb's writeback errseq, which VFS inspects after this call.

	 */

	if (ret < 0) {

		errseq_set(&sb->s_wb_err, -EIO);



	if (ret < 0)

		return -EIO;

	}



	if (!ret)

		return ret;