Commit 34c9cd82 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd/display: Drop unnecessary 'rc' variable in amdgpu_dm_backlight_get_level() 



[Why]
amdgpu_dm_backlight_get_level() returns a boolean value but is assigned
to a variable named 'rc' which is generally used for return codes.

This can be confusing while looking at the code for other issues.

[How]
Drop the variable and just look directly at the return value of
amdgpu_dm_backlight_get_level() in the if statement.

Reviewed-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarWayne Lin <wayne.lin@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ca74cc42

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+1 −3
Original line number Diff line number Diff line
@@ -4926,10 +4926,8 @@ static u32 amdgpu_dm_backlight_get_level(struct amdgpu_display_manager *dm, 


	if (caps.aux_support) {

		u32 avg, peak;

		bool rc;



		rc = dc_link_get_backlight_level_nits(link, &avg, &peak);

		if (!rc)

		if (!dc_link_get_backlight_level_nits(link, &avg, &peak))

			return dm->brightness[bl_idx];

		return convert_brightness_to_user(&caps, avg);

	}