Commit 34eec1f2 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Put the TX producer information in the TX BD opaque field 



Currently, the opaque field in the TX BD is only used for debugging.
The TX completion logic relies on getting one TX completion for each
packet and they always complete in order.

Improve this scheme by putting the producer information (ring index plus
number of BDs for the packet) in the opaque field.  This way, we can
handle TX completion processing by looking at the last TX completion
instead of counting the number of completions.

Since we no longer need to count the exact number of completions, we can
optimize xmit_more by disabling TX completion when the xmit_more
condition is true.  This will be done in later patches.

This patch is only initializing the opaque field in the TX BD and is
not changing the driver's TX completion logic yet.

Reviewed-by: default avatarAndy Gospodarek <gospo@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b3d8c605

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+3 −2
Original line number Diff line number Diff line
@@ -432,8 +432,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	txbd = &txr->tx_desc_ring[TX_RING(prod)][TX_IDX(prod)];



	txbd->tx_bd_opaque = prod;



	tx_buf = &txr->tx_buf_ring[prod];

	tx_buf->skb = skb;

	tx_buf->nr_frags = last_frag;
@@ -519,7 +517,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev) 


		txbd->tx_bd_len_flags_type = tx_push->tx_bd_len_flags_type;

		txbd->tx_bd_haddr = txr->data_mapping;

		txbd->tx_bd_opaque = SET_TX_OPAQUE(bp, prod, 2);

		prod = NEXT_TX(prod);

		tx_push->tx_bd_opaque = txbd->tx_bd_opaque;

		txbd = &txr->tx_desc_ring[TX_RING(prod)][TX_IDX(prod)];

		memcpy(txbd, tx_push1, sizeof(*txbd));

		prod = NEXT_TX(prod);
@@ -562,6 +562,7 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev) 
		((last_frag + 2) << TX_BD_FLAGS_BD_CNT_SHIFT);



	txbd->tx_bd_haddr = cpu_to_le64(mapping);

	txbd->tx_bd_opaque = SET_TX_OPAQUE(bp, prod, 2 + last_frag);



	prod = NEXT_TX(prod);

	txbd1 = (struct tx_bd_ext *)

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+7 −0
Original line number Diff line number Diff line
@@ -61,6 +61,13 @@ struct tx_bd { 
	__le64 tx_bd_haddr;

} __packed;



#define TX_OPAQUE_IDX_MASK	0x0000ffff

#define TX_OPAQUE_BDS_MASK	0x00ff0000

#define TX_OPAQUE_BDS_SHIFT	16



#define SET_TX_OPAQUE(bp, idx, bds)					\

	(((bds) << TX_OPAQUE_BDS_SHIFT) | ((idx) & (bp)->tx_ring_mask))



struct tx_bd_ext {

	__le32 tx_bd_hsize_lflags;

	#define TX_BD_FLAGS_TCP_UDP_CHKSUM			(1 << 0)

drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ struct bnxt_sw_tx_bd *bnxt_xmit_bd(struct bnxt *bp, 
		((num_frags + 1) << TX_BD_FLAGS_BD_CNT_SHIFT) |

		bnxt_lhint_arr[len >> 9];

	txbd->tx_bd_len_flags_type = cpu_to_le32(flags);

	txbd->tx_bd_opaque = prod;

	txbd->tx_bd_opaque = SET_TX_OPAQUE(bp, prod, 1 + num_frags);

	txbd->tx_bd_haddr = cpu_to_le64(mapping);



	/* now let us fill up the frags into the next buffers */