Commit 34fbf48c authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/ocrdma: Don't NULL deref uctx on errors in ocrdma_copy_pd_uresp() 

Sashiko points out that pd->uctx isn't initialized until late in the
function so all these error flow references are NULL and will crash. Use
the uctx that isn't NULL.

Cc: stable@vger.kernel.org
Fixes: fe2caefc ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4
Link: https://patch.msgid.link/r/9-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com


Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ea4e4b16

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

+2 −2
Original line number Diff line number Diff line
@@ -620,9 +620,9 @@ static int ocrdma_copy_pd_uresp(struct ocrdma_dev *dev, struct ocrdma_pd *pd, 


ucopy_err:

	if (pd->dpp_enabled)

		ocrdma_del_mmap(pd->uctx, dpp_page_addr, PAGE_SIZE);

		ocrdma_del_mmap(uctx, dpp_page_addr, PAGE_SIZE);

dpp_map_err:

	ocrdma_del_mmap(pd->uctx, db_page_addr, db_page_size);

	ocrdma_del_mmap(uctx, db_page_addr, db_page_size);

	return status;

}