Commit 35049a98 authored by Andrew Davis's avatar Andrew Davis Committed by Bjorn Andersson
Browse files

remoteproc: qcom_q6v5_pas: Use devm_rproc_alloc() helper 



Use the device lifecycle managed allocation function. This helps prevent
mistakes like freeing out of order in cleanup functions and forgetting to
free on error paths.

Signed-off-by: default avatarAndrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240123184632.725054-5-afd@ti.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 2f09fa9f

drivers/remoteproc/qcom_q6v5_pas.c

+1 −3
Original line number Diff line number Diff line
@@ -705,7 +705,7 @@ static int adsp_probe(struct platform_device *pdev) 
	if (desc->minidump_id)

		ops = &adsp_minidump_ops;



	rproc = rproc_alloc(&pdev->dev, pdev->name, ops, fw_name, sizeof(*adsp));

	rproc = devm_rproc_alloc(&pdev->dev, pdev->name, ops, fw_name, sizeof(*adsp));



	if (!rproc) {

		dev_err(&pdev->dev, "unable to allocate remoteproc\n");
@@ -784,7 +784,6 @@ static int adsp_probe(struct platform_device *pdev) 
	adsp_pds_detach(adsp, adsp->proxy_pds, adsp->proxy_pd_count);

free_rproc:

	device_init_wakeup(adsp->dev, false);

	rproc_free(rproc);



	return ret;

}
@@ -803,7 +802,6 @@ static void adsp_remove(struct platform_device *pdev) 
	qcom_remove_ssr_subdev(adsp->rproc, &adsp->ssr_subdev);

	adsp_pds_detach(adsp, adsp->proxy_pds, adsp->proxy_pd_count);

	device_init_wakeup(adsp->dev, false);

	rproc_free(adsp->rproc);

}



static const struct adsp_data adsp_resource_init = {