Commit 351ea48a authored by Al Viro's avatar Al Viro
Browse files

rust_binderfs: fix a dentry leak 



Parallel to binderfs patches - 02da8d2c "binderfs_binder_ctl_create():
kill a bogus check" and the bit of b89aa544 "convert binderfs" that
got lost when making 4433d8e2 "convert rust_binderfs"; the former is
a cleanup, the latter is about marking /binder-control persistent, so that
it would be taken out on umount.

Fixes: 4433d8e2 ("convert rust_binderfs")
Acked-by: default avatarAlice Ryhl <aliceryhl@google.com>
Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 63804fed

drivers/android/binder/rust_binderfs.c

+2 −7
Original line number Diff line number Diff line
@@ -391,12 +391,6 @@ static int binderfs_binder_ctl_create(struct super_block *sb) 
	if (!device)

		return -ENOMEM;



	/* If we have already created a binder-control node, return. */

	if (info->control_dentry) {

		ret = 0;

		goto out;

	}



	ret = -ENOMEM;

	inode = new_inode(sb);

	if (!inode)
@@ -431,7 +425,8 @@ static int binderfs_binder_ctl_create(struct super_block *sb) 


	inode->i_private = device;

	info->control_dentry = dentry;

	d_add(dentry, inode);

	d_make_persistent(dentry, inode);

	dput(dentry);



	return 0;