Unverified Commit 351f3d9a authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Ilpo Järvinen
Browse files

platform/x86/amd/pmc: Notify user when platform does not support s0ix transition 



Some of the AMD platforms do not support modern standby, so when such
CPU ID is detected, a warning message will be displayed to the user.

Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Co-developed-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20250305142615.410178-1-Shyam-sundar.S-k@amd.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 99923a0d

drivers/platform/x86/amd/pmc/pmc.c

+2 −1
Original line number Diff line number Diff line
@@ -808,6 +808,7 @@ static const struct pci_device_id pmc_pci_ids[] = { 
	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_PCO) },

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_RV) },

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SP) },

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SHP) },

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M20H_ROOT) },

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M60H_ROOT) },

	{ }
@@ -832,7 +833,7 @@ static int amd_pmc_probe(struct platform_device *pdev) 


	dev->cpu_id = rdev->device;



	if (dev->cpu_id == AMD_CPU_ID_SP) {

	if (dev->cpu_id == AMD_CPU_ID_SP || dev->cpu_id == AMD_CPU_ID_SHP) {

		dev_warn_once(dev->dev, "S0i3 is not supported on this hardware\n");

		err = -ENODEV;

		goto err_pci_dev_put;

drivers/platform/x86/amd/pmc/pmc.h

+1 −0
Original line number Diff line number Diff line
@@ -79,6 +79,7 @@ void amd_mp2_stb_deinit(struct amd_pmc_dev *dev); 
#define AMD_CPU_ID_CB			0x14D8

#define AMD_CPU_ID_PS			0x14E8

#define AMD_CPU_ID_SP			0x14A4

#define AMD_CPU_ID_SHP			0x153A

#define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT 0x1507

#define PCI_DEVICE_ID_AMD_1AH_M60H_ROOT 0x1122

#define PCI_DEVICE_ID_AMD_MP2_STB	0x172c