Unverified Commit 351fa2ff authored by Osama Abdelkader's avatar Osama Abdelkader Committed by Rodrigo Vivi
Browse files

drm/xe: Add missing newlines to drm_warn messages 



The drm_warn() calls in the default cases of various switch statements
in xe_vm.c were missing trailing newlines, which can cause log messages
to be concatenated with subsequent output. Add '\n' to all affected
messages.

Signed-off-by: default avatarOsama Abdelkader <osama.abdelkader@gmail.com>
Link: https://patch.msgid.link/20251224212116.59021-1-osama.abdelkader@gmail.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 96d45e34

drivers/gpu/drm/xe/xe_vm.c

+7 −7
Original line number Diff line number Diff line
@@ -2209,7 +2209,7 @@ static void print_op(struct xe_device *xe, struct drm_gpuva_op *op) 
		       (ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma));

		break;

	default:

		drm_warn(&xe->drm, "NOT POSSIBLE");

		drm_warn(&xe->drm, "NOT POSSIBLE\n");

	}

}

#else
@@ -2312,7 +2312,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops, 
		xe_bo_unlock(bo);

		break;

	default:

		drm_warn(&vm->xe->drm, "NOT POSSIBLE");

		drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

		ops = ERR_PTR(-EINVAL);

	}

	if (IS_ERR(ops))
@@ -2584,7 +2584,7 @@ static int xe_vma_op_commit(struct xe_vm *vm, struct xe_vma_op *op) 
		op->flags |= XE_VMA_OP_COMMITTED;

		break;

	default:

		drm_warn(&vm->xe->drm, "NOT POSSIBLE");

		drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

	}



	return err;
@@ -2783,7 +2783,7 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct drm_gpuva_ops *ops, 


			break;

		default:

			drm_warn(&vm->xe->drm, "NOT POSSIBLE");

			drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

		}



		err = xe_vma_op_commit(vm, op);
@@ -2845,7 +2845,7 @@ static void xe_vma_op_unwind(struct xe_vm *vm, struct xe_vma_op *op, 
		/* Nothing to do */

		break;

	default:

		drm_warn(&vm->xe->drm, "NOT POSSIBLE");

		drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

	}

}
@@ -3029,7 +3029,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm, 
		break;

	}

	default:

		drm_warn(&vm->xe->drm, "NOT POSSIBLE");

		drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

	}



	return err;
@@ -3268,7 +3268,7 @@ static void op_add_ufence(struct xe_vm *vm, struct xe_vma_op *op, 
		vma_add_ufence(gpuva_to_vma(op->base.prefetch.va), ufence);

		break;

	default:

		drm_warn(&vm->xe->drm, "NOT POSSIBLE");

		drm_warn(&vm->xe->drm, "NOT POSSIBLE\n");

	}

}