Commit 352899fd authored by Kaushlendra Kumar's avatar Kaushlendra Kumar Committed by Rafael J. Wysocki
Browse files

PM: wakeup: Delete timer before removing wakeup source from list 



Replace timer_delete_sync() with timer_shutdown_sync() and move
it before list_del_rcu() in wakeup_source_remove() to improve the
cleanup ordering and code clarity.

This ensures that the timer is stopped before removing the wakeup
source from the events list, providing a more logical cleanup
sequence.

While the current ordering is functionally correct, stopping the
timer first makes the cleanup flow more intuitive and follows the
general pattern of disabling active components before removing data
structures.

Signed-off-by: default avatarKaushlendra Kumar <kaushlendra.kumar@intel.com>
[ rjw: Subject and changelog edits ]
Link: https://patch.msgid.link/20251027044127.2456365-1-kaushlendra.kumar@intel.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 39ce15a4

drivers/base/power/wakeup.c

+1 −7
Original line number Diff line number Diff line
@@ -189,17 +189,11 @@ static void wakeup_source_remove(struct wakeup_source *ws) 
	if (WARN_ON(!ws))

		return;



	timer_shutdown_sync(&ws->timer);

	raw_spin_lock_irqsave(&events_lock, flags);

	list_del_rcu(&ws->entry);

	raw_spin_unlock_irqrestore(&events_lock, flags);

	synchronize_srcu(&wakeup_srcu);



	timer_delete_sync(&ws->timer);

	/*

	 * Clear timer.function to make wakeup_source_not_registered() treat

	 * this wakeup source as not registered.

	 */

	ws->timer.function = NULL;

}



/**