Commit 354ad60e authored by Usama Arif's avatar Usama Arif Committed by Vlastimil Babka
Browse files

mm: slub: only warn once when allocating slab obj extensions fails 



In memory bound systems, a large number of warnings for failing this
allocation repeatedly may mask any real issues in the system
during memory pressure being reported in dmesg. Change this to
warning only once.

Signed-off-by: default avatarUsama Arif <usamaarif642@gmail.com>
Reported-by: default avatarVlad Poenaru <vlad.wing@gmail.com>
Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/


Reviewed-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Acked-by: default avatarHarry Yoo <harry.yoo@oracle.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
parent 46459154

mm/slub.c

+4 −3
Original line number Diff line number Diff line
@@ -2102,10 +2102,11 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) 


	slab = virt_to_slab(p);

	if (!slab_obj_exts(slab) &&

	    WARN(alloc_slab_obj_exts(slab, s, flags, false),

		 "%s, %s: Failed to create slab extension vector!\n",

		 __func__, s->name))

	    alloc_slab_obj_exts(slab, s, flags, false)) {

		pr_warn_once("%s, %s: Failed to create slab extension vector!\n",

			     __func__, s->name);

		return NULL;

	}



	return slab_obj_exts(slab) + obj_to_index(s, slab, p);

}