Commit 3558ab79 authored by Matt Johnston's avatar Matt Johnston Committed by Paolo Abeni
Browse files

net: mctp: mctp_test_route_extaddr_input cleanup 



The sock was not being released. Other than leaking, the stale socket
will conflict with subsequent bind() calls in unrelated MCTP tests.

Fixes: 46ee1646 ("net: mctp: test: Add extaddr routing output test")
Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
Link: https://patch.msgid.link/20250710-mctp-bind-v4-1-8ec2f6460c56@codeconstruct.com.au


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a8594c95

net/mctp/test/route-test.c

+2 −4
Original line number Diff line number Diff line
@@ -1164,8 +1164,6 @@ static void mctp_test_route_extaddr_input(struct kunit *test) 
	rc = mctp_dst_input(&dst, skb);

	KUNIT_ASSERT_EQ(test, rc, 0);



	mctp_test_dst_release(&dst, &tpq);



	skb2 = skb_recv_datagram(sock->sk, MSG_DONTWAIT, &rc);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, skb2);

	KUNIT_ASSERT_EQ(test, skb2->len, len);
@@ -1179,8 +1177,8 @@ static void mctp_test_route_extaddr_input(struct kunit *test) 
	KUNIT_EXPECT_EQ(test, cb2->halen, sizeof(haddr));

	KUNIT_EXPECT_MEMEQ(test, cb2->haddr, haddr, sizeof(haddr));



	skb_free_datagram(sock->sk, skb2);

	mctp_test_destroy_dev(dev);

	kfree_skb(skb2);

	__mctp_route_test_fini(test, dev, &dst, &tpq, sock);

}



static void mctp_test_route_gw_lookup(struct kunit *test)