Commit 3565522e authored by Kevin Brodsky's avatar Kevin Brodsky Committed by Andrew Morton
Browse files

parisc: mm: ensure pagetable_pmd_[cd]tor are called 

The implementation of pmd_{alloc_one,free} on parisc requires a non-zero
allocation order, but is completely standard aside from that.  Let's reuse
the generic implementation of pmd_alloc_one().  Explicit zeroing is not
needed as GFP_PGTABLE_KERNEL includes __GFP_ZERO.  The generic pmd_free()
can handle higher allocation orders so we don't need to define our own.

These changes ensure that pagetable_pmd_[cd]tor are called, improving the
accounting of page table pages.

Link: https://lkml.kernel.org/r/20250103184415.2744423-3-kevin.brodsky@arm.com


Signed-off-by: default avatarKevin Brodsky <kevin.brodsky@arm.com>
Acked-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Acked-by: default avatarQi Zheng <zhengqi.arch@bytedance.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Mike Rapoport (Microsoft) <rppt@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 11e2400b

arch/parisc/include/asm/pgalloc.h

+12 −11
Original line number Diff line number Diff line
@@ -11,7 +11,6 @@ 
#include <asm/cache.h>



#define __HAVE_ARCH_PMD_ALLOC_ONE

#define __HAVE_ARCH_PMD_FREE

#define __HAVE_ARCH_PGD_FREE

#include <asm-generic/pgalloc.h>
@@ -46,17 +45,19 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd) 


static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)

{

	pmd_t *pmd;

	struct ptdesc *ptdesc;

	gfp_t gfp = GFP_PGTABLE_USER;



	pmd = (pmd_t *)__get_free_pages(GFP_PGTABLE_KERNEL, PMD_TABLE_ORDER);

	if (likely(pmd))

		memset ((void *)pmd, 0, PAGE_SIZE << PMD_TABLE_ORDER);

	return pmd;

	if (mm == &init_mm)

		gfp = GFP_PGTABLE_KERNEL;

	ptdesc = pagetable_alloc(gfp, PMD_TABLE_ORDER);

	if (!ptdesc)

		return NULL;

	if (!pagetable_pmd_ctor(ptdesc)) {

		pagetable_free(ptdesc);

		return NULL;

	}



static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)

{

	free_pages((unsigned long)pmd, PMD_TABLE_ORDER);

	return ptdesc_address(ptdesc);

}

#endif